PMD Results

The following document contains the results of PMD.

Summary

Files Errors
206 713

Files

Files Violations
org/jasig/portal/ChannelFactory.java 3
org/jasig/portal/ChannelIncorporationFilter.java 1
org/jasig/portal/ChannelManager.java 3
org/jasig/portal/ChannelRenderer.java 3
org/jasig/portal/ChannelRendererFactory.java 1
org/jasig/portal/ChannelRenderingBuffer.java 4
org/jasig/portal/CharacterCachingChannelIncorporationFilter.java 1
org/jasig/portal/EntityTypes.java 3
org/jasig/portal/ExceptionHelper.java 2
org/jasig/portal/GuestUserInstance.java 4
org/jasig/portal/GuestUserPreferencesManager.java 5
org/jasig/portal/MultipartDataSource.java 1
org/jasig/portal/PortalEvent.java 1
org/jasig/portal/PortalEventSource.java 1
org/jasig/portal/PortalSessionManager.java 2
org/jasig/portal/RDBMChannelRegistryStore.java 7
org/jasig/portal/RDBMPortletPreferencesStore.java 26
org/jasig/portal/RDBMUserIdentityStore.java 21
org/jasig/portal/ReferenceSequenceGenerator.java 1
org/jasig/portal/StandaloneChannelRenderer.java 4
org/jasig/portal/StructureStylesheetUserPreferences.java 2
org/jasig/portal/ThemeStylesheetUserPreferences.java 1
org/jasig/portal/UPFileSpec.java 1
org/jasig/portal/UserInstance.java 4
org/jasig/portal/UserProfile.java 1
org/jasig/portal/car/CarClassLoader.java 1
org/jasig/portal/car/CarResources.java 2
org/jasig/portal/car/ChannelDefinitionTagHandler.java 3
org/jasig/portal/car/Path.java 1
org/jasig/portal/car/ResourceResolver.java 3
org/jasig/portal/channels/CAbstractXslt.java 2
org/jasig/portal/channels/CChannelManager.java 1
org/jasig/portal/channels/CGenericXSLT.java 4
org/jasig/portal/channels/CNumberGuess.java 3
org/jasig/portal/channels/CTimeTitle.java 5
org/jasig/portal/channels/DLMUserPreferences/CUserPreferences.java 2
org/jasig/portal/channels/DLMUserPreferences/GPreferencesState.java 4
org/jasig/portal/channels/DLMUserPreferences/ManageProfilesState.java 10
org/jasig/portal/channels/DLMUserPreferences/TabColumnPrefsState.java 5
org/jasig/portal/channels/UserPreferences/CUserPreferences.java 2
org/jasig/portal/channels/UserPreferences/GPreferencesState.java 4
org/jasig/portal/channels/UserPreferences/ManageProfilesState.java 10
org/jasig/portal/channels/UserPreferences/TabColumnPrefsState.java 5
org/jasig/portal/channels/cusermanager/provider/DefaultDataHandlerImpl.java 2
org/jasig/portal/channels/groupsmanager/CGroupsManager.java 4
org/jasig/portal/channels/groupsmanager/CGroupsManagerServantFactory.java 2
org/jasig/portal/channels/groupsmanager/GroupsManagerXML.java 5
org/jasig/portal/channels/groupsmanager/SearchResultsGroupImpl.java 1
org/jasig/portal/channels/groupsmanager/Utility.java 5
org/jasig/portal/channels/groupsmanager/commands/CollapseGroup.java 1
org/jasig/portal/channels/groupsmanager/commands/DoneWithSelection.java 1
org/jasig/portal/channels/groupsmanager/commands/GroupsManagerCommand.java 1
org/jasig/portal/channels/groupsmanager/wrappers/GroupMemberWrapper.java 1
org/jasig/portal/channels/permissionsmanager/CPermissionsManager.java 1
org/jasig/portal/channels/permissionsmanager/PermissionsXML.java 1
org/jasig/portal/channels/permissionsmanager/commands/SelectActivities.java 1
org/jasig/portal/channels/permissionsmanager/commands/SelectTargets.java 1
org/jasig/portal/channels/portlet/CPortletAdapter.java 2
org/jasig/portal/channels/webproxy/CWebProxy.java 35
org/jasig/portal/channels/webproxy/CWebProxyXHTMLURLFilter.java 1
org/jasig/portal/concurrency/caching/LRUCache.java 1
org/jasig/portal/concurrency/caching/RDBMCachedEntityInvalidationStore.java 1
org/jasig/portal/concurrency/caching/ReferenceEntityCachingService.java 6
org/jasig/portal/concurrency/caching/ReferenceInvalidatingEntityCache.java 2
org/jasig/portal/concurrency/locking/MemoryEntityLockStore.java 2
org/jasig/portal/concurrency/locking/ReferenceEntityLockService.java 8
org/jasig/portal/container/binding/PortletApplicationUnmarshaller.java 1
org/jasig/portal/container/binding/WebApplicationUnmarshaller.java 2
org/jasig/portal/container/deploy/Deployer.java 2
org/jasig/portal/container/factory/ControllerFactoryImpl.java 2
org/jasig/portal/container/factory/ObjectIDFactoryImpl.java 2
org/jasig/portal/container/services/information/InformationProviderServiceImpl.java 1
org/jasig/portal/container/services/information/PortletStateManager.java 4
org/jasig/portal/container/services/information/PortletURLProviderImpl.java 1
org/jasig/portal/container/services/information/StaticInformationProviderImpl.java 1
org/jasig/portal/container/services/log/LogServiceImpl.java 2
org/jasig/portal/container/servlet/ServletResponseFactoryImpl.java 1
org/jasig/portal/container/servlet/ServletResponseImpl.java 1
org/jasig/portal/container/servlet/StoredServletResponseImpl.java 1
org/jasig/portal/core/ObjectIdFactory.java 1
org/jasig/portal/core/PropertiesManager.java 1
org/jasig/portal/groups/ComponentGroupServiceDescriptor.java 2
org/jasig/portal/groups/EntityImpl.java 1
org/jasig/portal/groups/GroupMemberImpl.java 3
org/jasig/portal/groups/PersonDirNameFinder.java 1
org/jasig/portal/groups/RDBMEntityGroupStore.java 2
org/jasig/portal/groups/ReferenceCompositeGroupService.java 2
org/jasig/portal/groups/ReferenceIndividualGroupService.java 2
org/jasig/portal/groups/ReferencePersonNameFinder.java 1
org/jasig/portal/groups/filesystem/FileSystemEntitySearcherFactory.java 1
org/jasig/portal/groups/filesystem/FileSystemGroupStore.java 2
org/jasig/portal/groups/filesystem/FileSystemGroupStoreFactory.java 1
org/jasig/portal/groups/ldap/LDAPGroupStore.java 2
org/jasig/portal/groups/ldap/LDAPGroupStoreFactory.java 1
org/jasig/portal/groups/pags/PersonAttributesGroupStore.java 1
org/jasig/portal/groups/pags/testers/IntegerTester.java 1
org/jasig/portal/groups/pags/testers/RegexTester.java 1
org/jasig/portal/groups/pags/testers/ValueExistsTester.java 1
org/jasig/portal/groups/pags/testers/ValueMissingTester.java 1
org/jasig/portal/i18n/LocaleManager.java 2
org/jasig/portal/jndi/JNDIManager.java 2
org/jasig/portal/lang/ChainedError.java 5
org/jasig/portal/lang/ChainedException.java 5
org/jasig/portal/lang/ChainedRuntimeException.java 5
org/jasig/portal/lang/Resources.java 2
org/jasig/portal/lang/StackTrace.java 21
org/jasig/portal/lang/ThrowableHelper.java 13
org/jasig/portal/lang/TypeConverter.java 19
org/jasig/portal/layout/TransientUserLayoutManagerWrapper.java 3
org/jasig/portal/layout/alm/AggregatedLayout.java 2
org/jasig/portal/layout/alm/AggregatedLayoutManager.java 9
org/jasig/portal/layout/alm/AggregatedUserLayoutStore.java 46
org/jasig/portal/layout/alm/channels/CContentSubscriber.java 1
org/jasig/portal/layout/alm/channels/CFragmentManager.java 2
org/jasig/portal/layout/channels/CSkinSelector.java 1
org/jasig/portal/layout/dlm/ConfigurationLoader.java 1
org/jasig/portal/layout/dlm/DeleteManager.java 1
org/jasig/portal/layout/dlm/DistributedLayoutManager.java 1
org/jasig/portal/layout/dlm/DistributedUserPreferences.java 3
org/jasig/portal/layout/dlm/FragmentActivator.java 1
org/jasig/portal/layout/dlm/FragmentComparator.java 1
org/jasig/portal/layout/dlm/NodeInfo.java 1
org/jasig/portal/layout/dlm/PLFIntegrator.java 1
org/jasig/portal/layout/dlm/RDBMDistributedLayoutStore.java 2
org/jasig/portal/layout/node/NodeIdFactory.java 1
org/jasig/portal/layout/node/UserLayoutChannelDescription.java 7
org/jasig/portal/layout/node/UserLayoutNodeDescription.java 6
org/jasig/portal/layout/restrictions/alm/ALRestrictionManager.java 1
org/jasig/portal/layout/restrictions/alm/DepthRestriction.java 2
org/jasig/portal/layout/simple/RDBMUserLayoutStore.java 12
org/jasig/portal/layout/simple/SimpleUserLayoutManager.java 1
org/jasig/portal/ldap/LdapServices.java 1
org/jasig/portal/properties/PropertiesManager.java 3
org/jasig/portal/rdbm/DatabaseMetaDataImpl.java 1
org/jasig/portal/security/provider/AuthorizationImpl.java 1
org/jasig/portal/security/provider/BrokenSecurityContext.java 1
org/jasig/portal/security/provider/CacheSecurityContext.java 1
org/jasig/portal/security/provider/ChainingSecurityContext.java 1
org/jasig/portal/security/provider/JAASSecurityContext.java 1
org/jasig/portal/security/provider/RemoteUserSecurityContext.java 1
org/jasig/portal/security/provider/SimpleLdapSecurityContext.java 1
org/jasig/portal/security/provider/SimpleSecurityContext.java 1
org/jasig/portal/security/provider/TrustSecurityContext.java 1
org/jasig/portal/security/provider/cas/CasConnectionContext.java 1
org/jasig/portal/security/provider/cas/CasFilteredSecurityContext.java 1
org/jasig/portal/security/provider/cas/CasSecurityContext.java 1
org/jasig/portal/serialize/BaseMarkupSerializer.java 7
org/jasig/portal/serialize/HTMLSerializer.java 4
org/jasig/portal/serialize/HTMLdtd.java 2
org/jasig/portal/serialize/OutputFormat.java 3
org/jasig/portal/serialize/ProxyWriter.java 1
org/jasig/portal/serialize/SerializerFactory.java 1
org/jasig/portal/serialize/SieveEncodingInfo.java 1
org/jasig/portal/serialize/TextSerializer.java 2
org/jasig/portal/serialize/XHTMLSerializer.java 2
org/jasig/portal/serialize/XMLSerializer.java 1
org/jasig/portal/services/Authentication.java 1
org/jasig/portal/services/ExternalServices.java 3
org/jasig/portal/services/GroupService.java 1
org/jasig/portal/services/LogService.java 6
org/jasig/portal/services/StatsRecorder.java 1
org/jasig/portal/services/dom/DOMInitService.java 2
org/jasig/portal/services/dom/DOMInitServiceFactory.java 1
org/jasig/portal/services/persondir/support/LdapPersonAttributeDaoImpl.java 1
org/jasig/portal/services/persondir/support/legacy/PersonDirInfo.java 1
org/jasig/portal/tools/ChannelServlet.java 1
org/jasig/portal/tools/DbConvert21.java 2
org/jasig/portal/tools/DbTest.java 3
org/jasig/portal/tools/DeleteUser.java 5
org/jasig/portal/tools/LibCheck.java 1
org/jasig/portal/tools/RegisterStylesheet.java 4
org/jasig/portal/tools/SimpleLayout2ALIM.java 1
org/jasig/portal/tools/chanpub/ChannelPublisher.java 1
org/jasig/portal/tools/checks/JaxpCheck.java 1
org/jasig/portal/tools/dbloader/DataHandler.java 12
org/jasig/portal/tools/dbloader/DbUnload.java 1
org/jasig/portal/tools/dbloader/DbUtils.java 3
org/jasig/portal/tools/dbloader/DomUtils.java 1
org/jasig/portal/tools/versioning/Version.java 1
org/jasig/portal/utils/AddressTester.java 1
org/jasig/portal/utils/CookieCutter.java 3
org/jasig/portal/utils/PortalDocumentImpl.java 1
org/jasig/portal/utils/RDBMCounterStore.java 7
org/jasig/portal/utils/SAX2BufferImpl.java 5
org/jasig/portal/utils/SAX2FilterImpl.java 3
org/jasig/portal/utils/SoftHashMap.java 1
org/jasig/portal/utils/SubstitutionWriter.java 1
org/jasig/portal/utils/ThreadPool.java 4
org/jasig/portal/utils/cache/CacheFactoryLocator.java 1
org/jasig/portal/wsrp/consumer/portlet/ConsumerEnvironmentImpl.java 1
rg/jasig/portal/SequenceGeneratorTester.java 4
rg/jasig/portal/UPFileSpecTest.java 2
rg/jasig/portal/concurrency/caching/EntityCacheTester.java 4
rg/jasig/portal/concurrency/locking/EntityLockTest.java 2
rg/jasig/portal/groups/GroupsTester.java 29
rg/jasig/portal/groups/filesystem/FileSystemGroupsTest.java 10
rg/jasig/portal/groups/pags/PAGSTest.java 1
rg/jasig/portal/lang/ChainedThrowable_Test.java 4
rg/jasig/portal/lang/ThrowableHelper_Test.java 9
rg/jasig/portal/lang/TypeConverter_Test.java 21
rg/jasig/portal/layout/UserLayoutStoreMock.java 1
rg/jasig/portal/layout/simple/SimpleUserLayoutManagerTest.java 2
rg/jasig/portal/ldap/LdapServerImplTest.java 4
rg/jasig/portal/security/provider/AuthorizationTester.java 10
rg/jasig/portal/security/provider/BasicLocalConnectionContextTest.java 1
rg/jasig/portal/services/persondir/support/legacy/PersonDirInfoTest.java 2

org/jasig/portal/ChannelFactory.java

Violation Line
Avoid unused formal parameters such as 'channelPublishId' 78
Avoid unused formal parameters such as 'params' 78
Avoid unused formal parameters such as 'timeOut' 78

org/jasig/portal/ChannelIncorporationFilter.java

Violation Line
These nested if statements could be combined 72

org/jasig/portal/ChannelManager.java

Violation Line
Avoid unused formal parameters such as 'commonMessage' 471
Avoid empty catch blocks 815
Avoid unused private methods such as 'startChannelRendering' 1063

org/jasig/portal/ChannelRenderer.java

Violation Line
These nested if statements could be combined 140
Avoid empty catch blocks 292
These nested if statements could be combined 673

org/jasig/portal/ChannelRendererFactory.java

Violation Line
Unnecessary final modifier in final class 49

org/jasig/portal/ChannelRenderingBuffer.java

Violation Line
Avoid unused private fields such as 'channelClassName' 41
Avoid unused private fields such as 'channelPublishId' 43
Avoid unused private fields such as 'timeOut' 44
These nested if statements could be combined 126

org/jasig/portal/CharacterCachingChannelIncorporationFilter.java

Violation Line
Avoid unused local variables such as 'noAttributes' 307

org/jasig/portal/EntityTypes.java

Violation Line
Avoid unused private methods such as 'deleteEntityType' 166
Avoid empty catch blocks 380
Avoid unused private methods such as 'updateEntityType' 582

org/jasig/portal/ExceptionHelper.java

Violation Line
Avoid unused private methods such as 'signal' 200
An empty statement (semicolon) not part of a loop 326

org/jasig/portal/GuestUserInstance.java

Violation Line
Avoid unused private fields such as 'channelManager' 35
Avoid unused private fields such as 'localeManager' 36
Avoid unused private fields such as 'p_browserMapper' 37
Avoid unused private fields such as 'p_rendering_lock' 38

org/jasig/portal/GuestUserPreferencesManager.java

Violation Line
Avoid unused private fields such as 'tsd' 41
Avoid unused private fields such as 'ssd' 42
Avoid unused private fields such as 'unmapped_user_agent' 43
Avoid unused private fields such as 'complete_up' 44
Avoid unused private fields such as 'ulm' 45

org/jasig/portal/MultipartDataSource.java

Violation Line
Avoid empty catch blocks 64

org/jasig/portal/PortalEvent.java

Violation Line
Ensure you override both equals() and hashCode() 192

org/jasig/portal/PortalEventSource.java

Violation Line
Ensure you override both equals() and hashCode() 47

org/jasig/portal/PortalSessionManager.java

Violation Line
Avoid unused local variables such as 'startTime' 246
Avoid empty catch blocks 285

org/jasig/portal/RDBMChannelRegistryStore.java

Violation Line
Avoid unused local variables such as 'rows' 284
Avoid empty catch blocks 491
Avoid empty catch blocks 492
Avoid empty catch blocks 493
Avoid empty catch blocks 494
Avoid empty catch blocks 495
Avoid unused local variables such as 'recordsDeleted' 648

org/jasig/portal/RDBMPortletPreferencesStore.java

Violation Line
An empty statement (semicolon) not part of a loop 114
Avoid empty catch blocks 114
Avoid empty catch blocks 175
Avoid empty catch blocks 176
Avoid empty catch blocks 177
Avoid empty catch blocks 178
Avoid empty catch blocks 179
Avoid empty catch blocks 245
Avoid empty catch blocks 257
An empty statement (semicolon) not part of a loop 341
Avoid empty catch blocks 341
Avoid empty catch blocks 406
Avoid empty catch blocks 407
Avoid empty catch blocks 408
Avoid empty catch blocks 409
Avoid empty catch blocks 410
Avoid empty catch blocks 468
Avoid empty catch blocks 479
Avoid empty catch blocks 541
Avoid empty catch blocks 557
Avoid empty catch blocks 558
Avoid empty catch blocks 559
Avoid empty catch blocks 621
Avoid empty catch blocks 639
Avoid empty catch blocks 640
Avoid empty catch blocks 641

org/jasig/portal/RDBMUserIdentityStore.java

Violation Line
Avoid unused private fields such as 'guestUID' 36
Avoid empty catch blocks 211
Avoid empty catch blocks 354
Avoid empty catch blocks 357
Avoid empty catch blocks 360
Avoid empty catch blocks 411
Avoid empty catch blocks 414
Avoid empty catch blocks 417
Avoid empty catch blocks 444
Avoid empty catch blocks 447
Avoid empty catch blocks 450
Avoid empty catch blocks 649
Avoid empty catch blocks 653
Avoid empty catch blocks 654
Avoid empty catch blocks 655
Avoid empty catch blocks 664
Avoid unnecessary return statements 667
Avoid empty catch blocks 838
Avoid empty catch blocks 841
Avoid empty catch blocks 842
Avoid empty catch blocks 849

org/jasig/portal/ReferenceSequenceGenerator.java

Violation Line
Avoid unused private methods such as 'setCounter' 364

org/jasig/portal/StandaloneChannelRenderer.java

Violation Line
Avoid unused private fields such as 'hasEdit' 47
Avoid unused private fields such as 'hasAbout' 48
Avoid unused private fields such as 'hasHelp' 49
Avoid unused private fields such as 'fs' 53

org/jasig/portal/StructureStylesheetUserPreferences.java

Violation Line
Avoid unused local variables such as 'attributeNumber' 169
Avoid unused private methods such as 'copyFolderAttributeNames' 212

org/jasig/portal/ThemeStylesheetUserPreferences.java

Violation Line
Avoid unused local variables such as 'attributeNumber' 144

org/jasig/portal/UPFileSpec.java

Violation Line
These nested if statements could be combined 404

org/jasig/portal/UserInstance.java

Violation Line
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 192
These nested if statements could be combined 541
These nested if statements could be combined 804
These nested if statements could be combined 872

org/jasig/portal/UserProfile.java

Violation Line
Ensure you override both equals() and hashCode() 53

org/jasig/portal/car/CarClassLoader.java

Violation Line
Avoid empty catch blocks 159

org/jasig/portal/car/CarResources.java

Violation Line
Avoid unused private fields such as 'carDirExists' 74
Avoid empty catch blocks 462

org/jasig/portal/car/ChannelDefinitionTagHandler.java

Violation Line
Avoid empty catch blocks 68
Avoid empty catch blocks 115
These nested if statements could be combined 218

org/jasig/portal/car/Path.java

Violation Line
Ensure you override both equals() and hashCode() 111

org/jasig/portal/car/ResourceResolver.java

Violation Line
Avoid empty catch blocks 52
Avoid empty catch blocks 55
Avoid empty catch blocks 71

org/jasig/portal/channels/CAbstractXslt.java

Violation Line
These nested if statements could be combined 59
These nested if statements could be combined 78

org/jasig/portal/channels/CChannelManager.java

Violation Line
Avoid empty catch blocks 502

org/jasig/portal/channels/CGenericXSLT.java

Violation Line
Avoid unused imports such as 'org.jasig.portal.utils.uri.BlockedUriException' 42
Avoid unused private fields such as 'cacheTimeout' 136
Avoid unused private fields such as 'runtimeData' 137
Avoid unused private fields such as 'localConnContext' 138

org/jasig/portal/channels/CNumberGuess.java

Violation Line
Avoid importing anything from the package 'java.lang' 11
Avoid empty catch blocks 119
An empty statement (semicolon) not part of a loop 159

org/jasig/portal/channels/CTimeTitle.java

Violation Line
Unnecessary final modifier in final class 41
Unnecessary final modifier in final class 57
Unnecessary final modifier in final class 80
Unnecessary final modifier in final class 85
Unnecessary final modifier in final class 89

org/jasig/portal/channels/DLMUserPreferences/CUserPreferences.java

Violation Line
An empty statement (semicolon) not part of a loop 153
Avoid empty catch blocks 153

org/jasig/portal/channels/DLMUserPreferences/GPreferencesState.java

Violation Line
These nested if statements could be combined 234
These nested if statements could be combined 488
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 666
Avoid empty 'if' statements 744

org/jasig/portal/channels/DLMUserPreferences/ManageProfilesState.java

Violation Line
Avoid empty 'if' statements 148
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 173
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 175
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 209
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 217
Avoid unused local variables such as 'upList' 263
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 332
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 333
Avoid empty catch blocks 408
Avoid empty 'if' statements 596

org/jasig/portal/channels/DLMUserPreferences/TabColumnPrefsState.java

Violation Line
Avoid unused formal parameters such as 'elementId' 542
Avoid unused formal parameters such as 'locked' 542
Avoid unused formal parameters such as 'channelsAdded' 630
Avoid empty 'if' statements 919
Avoid unused local variables such as 'selectedChannel' 1216

org/jasig/portal/channels/UserPreferences/CUserPreferences.java

Violation Line
An empty statement (semicolon) not part of a loop 163
Avoid empty catch blocks 163

org/jasig/portal/channels/UserPreferences/GPreferencesState.java

Violation Line
These nested if statements could be combined 229
These nested if statements could be combined 479
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 652
Avoid empty 'if' statements 730

org/jasig/portal/channels/UserPreferences/ManageProfilesState.java

Violation Line
Avoid empty 'if' statements 145
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 170
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 172
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 206
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 214
Avoid unused local variables such as 'upList' 260
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 328
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead. 329
Avoid empty catch blocks 400
Avoid empty 'if' statements 588

org/jasig/portal/channels/UserPreferences/TabColumnPrefsState.java

Violation Line
These nested if statements could be combined 170
Avoid unused formal parameters such as 'elementId' 533
Avoid unused formal parameters such as 'locked' 533
Avoid empty 'if' statements 874
Avoid unused local variables such as 'selectedChannel' 1161

org/jasig/portal/channels/cusermanager/provider/DefaultDataHandlerImpl.java

Violation Line
These nested if statements could be combined 195
Avoid empty catch blocks 236

org/jasig/portal/channels/groupsmanager/CGroupsManager.java

Violation Line
These nested if statements could be combined 81
These nested if statements could be combined 98
Avoid unnecessary return statements 242
These nested if statements could be combined 461

org/jasig/portal/channels/groupsmanager/CGroupsManagerServantFactory.java

Violation Line
An empty statement (semicolon) not part of a loop 121
An empty statement (semicolon) not part of a loop 330

org/jasig/portal/channels/groupsmanager/GroupsManagerXML.java

Violation Line
Avoid unnecessary return statements 685
Avoid unnecessary return statements 713
Avoid unnecessary return statements 754
Avoid unnecessary return statements 790
Avoid unnecessary return statements 938

org/jasig/portal/channels/groupsmanager/SearchResultsGroupImpl.java

Violation Line
Ensure you override both equals() and hashCode() 91

org/jasig/portal/channels/groupsmanager/Utility.java

Violation Line
Avoid unnecessary return statements 66
Avoid unnecessary return statements 88
Avoid unnecessary return statements 136
Avoid unnecessary return statements 151
These nested if statements could be combined 251

org/jasig/portal/channels/groupsmanager/commands/CollapseGroup.java

Violation Line
Avoid unnecessary return statements 48

org/jasig/portal/channels/groupsmanager/commands/DoneWithSelection.java

Violation Line
An empty statement (semicolon) not part of a loop 87

org/jasig/portal/channels/groupsmanager/commands/GroupsManagerCommand.java

Violation Line
Avoid unnecessary return statements 62

org/jasig/portal/channels/groupsmanager/wrappers/GroupMemberWrapper.java

Violation Line
Avoid unnecessary return statements 71

org/jasig/portal/channels/permissionsmanager/CPermissionsManager.java

Violation Line
These nested if statements could be combined 368

org/jasig/portal/channels/permissionsmanager/PermissionsXML.java

Violation Line
These nested if statements could be combined 120

org/jasig/portal/channels/permissionsmanager/commands/SelectActivities.java

Violation Line
Avoid empty 'if' statements 77

org/jasig/portal/channels/permissionsmanager/commands/SelectTargets.java

Violation Line
Avoid empty 'if' statements 72

org/jasig/portal/channels/portlet/CPortletAdapter.java

Violation Line
Avoid unused local variables such as 'dip' 300
Avoid empty catch blocks 354

org/jasig/portal/channels/webproxy/CWebProxy.java

Violation Line
Avoid unused imports such as 'org.jasig.portal.utils.uri.BlockedUriException' 56
Avoid empty catch blocks 241
Avoid unused private fields such as 'publishId' 256
Avoid unused private fields such as 'iperson' 257
Avoid unused private fields such as 'person' 258
Avoid unused private fields such as 'personAllow' 259
Avoid unused private fields such as 'personAllow_set' 260
Avoid unused private fields such as 'fullxmlUri' 261
Avoid unused private fields such as 'buttonxmlUri' 267
Avoid unused private fields such as 'xmlUri' 274
Avoid unused private fields such as 'key' 275
Avoid unused private fields such as 'passThrough' 276
Avoid unused private fields such as 'tidy' 277
Avoid unused private fields such as 'sslUri' 283
Avoid unused private fields such as 'xslTitle' 284
Avoid unused private fields such as 'xslUri' 289
Avoid unused private fields such as 'infoUri' 294
Avoid unused private fields such as 'helpUri' 299
Avoid unused private fields such as 'editUri' 304
Avoid unused private fields such as 'cacheDefaultMode' 306
Avoid unused private fields such as 'cacheMode' 307
Avoid unused private fields such as 'reqParameters' 308
Avoid unused private fields such as 'cacheDefaultTimeout' 309
Avoid unused private fields such as 'cacheTimeout' 310
Avoid unused private fields such as 'runtimeData' 311
Avoid unused private fields such as 'cookieCutter' 312
Avoid unused private fields such as 'connHolder' 313
Avoid unused private fields such as 'localConnContext' 314
Avoid unused private fields such as 'refresh' 315
These nested if statements could be combined 571
Avoid empty catch blocks 875
These nested if statements could be combined 1000
These nested if statements could be combined 1011
These nested if statements could be combined 1022
These nested if statements could be combined 1049

org/jasig/portal/channels/webproxy/CWebProxyXHTMLURLFilter.java

Violation Line
These nested if statements could be combined 89

org/jasig/portal/concurrency/caching/LRUCache.java

Violation Line
These nested if statements could be combined 144

org/jasig/portal/concurrency/caching/RDBMCachedEntityInvalidationStore.java

Violation Line
Avoid unused private methods such as 'getSelectInvalidationsByTypeSql' 240

org/jasig/portal/concurrency/caching/ReferenceEntityCachingService.java

Violation Line
Avoid unused private methods such as 'createCaches' 107
Avoid empty catch blocks 164
Avoid empty catch blocks 172
Avoid empty catch blocks 179
Avoid empty catch blocks 187
Avoid empty catch blocks 196

org/jasig/portal/concurrency/caching/ReferenceInvalidatingEntityCache.java

Violation Line
Avoid unused local variables such as 'msg' 100
Avoid unused local variables such as 'ts' 102

org/jasig/portal/concurrency/locking/MemoryEntityLockStore.java

Violation Line
These nested if statements could be combined 156
Avoid unused private methods such as 'setLockCache' 243

org/jasig/portal/concurrency/locking/ReferenceEntityLockService.java

Violation Line
Avoid empty 'if' statements 87
Avoid unused private methods such as 'getDefaultLockPeriod' 115
Avoid empty catch blocks 165
Avoid empty catch blocks 174
Avoid unused private methods such as 'isLocked' 185
Avoid unused private methods such as 'isLocked' 198
Avoid unused private methods such as 'isMultiServer' 206
Avoid unused private methods such as 'setMultiServer' 410

org/jasig/portal/container/binding/PortletApplicationUnmarshaller.java

Violation