The following document contains the results of FindBugs Report
FindBugs Version is 1.0.0
Threshold is Low
Effort is Default
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.cache.CacheEntry.getContent() may expose internal representation by returning edu.wisc.my.webproxy.beans.cache.CacheEntry.content | MALICIOUS_CODE | EI_EXPOSE_REP | 60 |
| edu.wisc.my.webproxy.beans.cache.CacheEntry.getExpirationDate() may expose internal representation by returning edu.wisc.my.webproxy.beans.cache.CacheEntry.expirationDate | MALICIOUS_CODE | EI_EXPOSE_REP | 72 |
| edu.wisc.my.webproxy.beans.cache.CacheEntry.setContent(byte[]) may expose internal representation by storing an externally mutable object into edu.wisc.my.webproxy.beans.cache.CacheEntry.content | MALICIOUS_CODE | EI_EXPOSE_REP2 | 78 |
| edu.wisc.my.webproxy.beans.cache.CacheEntry.setExpirationDate(java.util.Date) may expose internal representation by storing an externally mutable object into edu.wisc.my.webproxy.beans.cache.CacheEntry.expirationDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 90 |
| edu.wisc.my.webproxy.beans.cache.CacheEntry is Serializable; consider declaring a serialVersionUID | CORRECTNESS | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.cache.oscache.CacheEntryRefreshPolicy is Serializable; consider declaring a serialVersionUID | CORRECTNESS | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Load of known null value in edu.wisc.my.webproxy.beans.cache.oscache.KeyHashingPersistenceListener.getKeyHash(String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 195 |
| Unsigned right shift cast to short/byte in edu.wisc.my.webproxy.beans.cache.oscache.KeyHashingPersistenceListener.byteArrayToHexString(byte[]) | STYLE | ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT | 248 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.config.CacheConfigImpl.process(javax.portlet.ActionRequest,javax.portlet.ActionResponse) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 81 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.config.ClippingConfigImpl.process(javax.portlet.ActionRequest,javax.portlet.ActionResponse) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 71 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.config.ConfigUtils.toBooleanArray(String[],boolean[]) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 87 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.config.HtmlParserConfigImpl.process(javax.portlet.ActionRequest,javax.portlet.ActionResponse) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 67 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.config.HttpClientConfigImpl.process(javax.portlet.ActionRequest,javax.portlet.ActionResponse) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 105 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method edu.wisc.my.webproxy.beans.filtering.BaseUrlFilter.startElement(String,String,String,org.xml.sax.Attributes) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 101 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method edu.wisc.my.webproxy.beans.filtering.ClippingFilter.comment(char[],int,int) invokes toString() method on a String; just use the String | PERFORMANCE | DM_STRING_TOSTRING | 307 |
| edu.wisc.my.webproxy.beans.filtering.ClippingFilter.setupFilter(javax.portlet.PortletRequest) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 350 |
| edu.wisc.my.webproxy.beans.filtering.ClippingFilter.setElement(String[]) may expose internal representation by storing an externally mutable object into edu.wisc.my.webproxy.beans.filtering.ClippingFilter.sElement | MALICIOUS_CODE | EI_EXPOSE_REP2 | 130 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method edu.wisc.my.webproxy.beans.filtering.FuncNameUrlFilter.doUrlRewite(String,int) invokes toString() method on a String; just use the String | PERFORMANCE | DM_STRING_TOSTRING | 101 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.filtering.NekoHtmlParser.setRenderData(javax.portlet.RenderRequest,javax.portlet.RenderResponse) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 114 |
| Method edu.wisc.my.webproxy.beans.filtering.NekoHtmlParser.getReader(org.xml.sax.ext.LexicalHandler) directly allocates a specific implementation of xml interfaces | STYLE | XFB_XML_FACTORY_BYPASS | 82 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.http.Credentials is Serializable; consider declaring a serialVersionUID | CORRECTNESS | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.http.HttpClientCookieImpl is Serializable; consider declaring a serialVersionUID | CORRECTNESS | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.http.HttpClientStateImpl is Serializable; consider declaring a serialVersionUID | CORRECTNESS | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.http.NtCredentials is Serializable; consider declaring a serialVersionUID | CORRECTNESS | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.beans.http.RequestImpl.setHeaders(Header[]) may expose internal representation by storing an externally mutable object into edu.wisc.my.webproxy.beans.http.RequestImpl.headers | MALICIOUS_CODE | EI_EXPOSE_REP2 | 101 |
| edu.wisc.my.webproxy.beans.http.RequestImpl.getHeaders() may expose internal representation by returning edu.wisc.my.webproxy.beans.http.RequestImpl.headers | MALICIOUS_CODE | EI_EXPOSE_REP | 108 |
| edu.wisc.my.webproxy.beans.http.RequestImpl.setParameters(ParameterPair[]) may expose internal representation by storing an externally mutable object into edu.wisc.my.webproxy.beans.http.RequestImpl.postAttributes | MALICIOUS_CODE | EI_EXPOSE_REP2 | 150 |
| edu.wisc.my.webproxy.beans.http.RequestImpl.getParameters() may expose internal representation by returning edu.wisc.my.webproxy.beans.http.RequestImpl.postAttributes | MALICIOUS_CODE | EI_EXPOSE_REP | 157 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should edu.wisc.my.webproxy.beans.PortletPreferencesWrapper.getValues(String,String[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 113 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.portlet.WebProxyPortlet.renderContent(javax.portlet.RenderRequest,javax.portlet.RenderResponse) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 238 |
| edu.wisc.my.webproxy.portlet.WebProxyPortlet.doHttpAuth(javax.portlet.PortletRequest,edu.wisc.my.webproxy.beans.http.Request) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 609 |
| edu.wisc.my.webproxy.portlet.WebProxyPortlet.doFormAuth(edu.wisc.my.webproxy.beans.http.HttpManager,javax.portlet.PortletRequest) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 649 |
| edu.wisc.my.webproxy.portlet.WebProxyPortlet.manualLogin(javax.portlet.RenderRequest,javax.portlet.RenderResponse) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 774 |
| edu.wisc.my.webproxy.portlet.WebProxyPortlet.processManualAuthForm(javax.portlet.ActionRequest) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 1186 |
| Method edu.wisc.my.webproxy.portlet.WebProxyPortlet.checkRedirect(String,edu.wisc.my.webproxy.beans.http.Response) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead | I18N | DM_CONVERT_CASE | 1249 |
| edu.wisc.my.webproxy.portlet.WebProxyPortlet.getState(javax.portlet.PortletRequest) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 1306 |
| edu.wisc.my.webproxy.portlet.WebProxyPortlet.storeState(javax.portlet.PortletRequest,edu.wisc.my.webproxy.beans.http.State) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 1335 |
| Write to static field edu.wisc.my.webproxy.portlet.WebProxyPortlet.instance from instance method edu.wisc.my.webproxy.portlet.WebProxyPortlet.destroy() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 134 |
| Write to static field edu.wisc.my.webproxy.portlet.WebProxyPortlet.instance from instance method edu.wisc.my.webproxy.portlet.WebProxyPortlet.init() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 141 |
| Bug | Category | Details | Line |
|---|---|---|---|
| edu.wisc.my.webproxy.servlet.ProxyServlet.doGet(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 153 |
| edu.wisc.my.webproxy.servlet.ProxyServlet is Serializable; consider declaring a serialVersionUID | CORRECTNESS | SE_NO_SERIALVERSIONID | Not available |
| Class edu.wisc.my.webproxy.servlet.ProxyServlet defines non-transient non-serializable instance field edu.wisc.my.webproxy.servlet.ProxyServlet.LOG | CORRECTNESS | SE_BAD_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.SpringList.wrappedList | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.cache.oscache.FilteringPersistenceListener.persistedGroups | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener.allObjectsDelete | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener.objectDelete | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener.objectExistsQuery | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener.objectInsert | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener.objectQuery | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener.objectUpdate | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.cache.oscache.OsCachePageCache.cacheAdmin | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.http.JdbcStateStore.allStatesDelete | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.http.JdbcStateStore.stateDelete | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.http.JdbcStateStore.stateExistsQuery | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.http.JdbcStateStore.stateInsert | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.http.JdbcStateStore.stateQuery | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Field not initialized in constructor: edu.wisc.my.webproxy.beans.http.JdbcStateStore.stateUpdate | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Should edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener$AllObjectsDelete be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener$ObjectDelete be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener$ObjectExistsQuery be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener$ObjectInsert be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.cache.oscache.JdbcPersistenceListener$ObjectUpdate be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.http.JdbcStateStore$AllStatesDelete be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.http.JdbcStateStore$StateDelete be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.http.JdbcStateStore$StateExistsQuery be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.http.JdbcStateStore$StateInsert be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Should edu.wisc.my.webproxy.beans.http.JdbcStateStore$StateUpdate be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
